Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61570 )
Change subject: [WIP] soc/amd/sabrina/i2c: only call fch_i2c_pad_init for bus 3
......................................................................
Patch Set 1:
(1 comment)
File src/soc/amd/sabrina/i2c.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139796):
https://review.coreboot.org/c/coreboot/+/61570/comment/3fc20a6c_bf364228
PS1, Line 45: if (bus <= 2) {
braces {} are not necessary for any arm of this statement
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61570
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie210c3437f2608d1e9fb99dcb151fc4190721375
Gerrit-Change-Number: 61570
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Comment-Date: Wed, 02 Feb 2022 22:20:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment