Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Subrata Banik.
Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58289 )
Change subject: soc/intel/adl: Skip sending MBP hob to save boot time
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/58289/comment/56e5ea79_ea0269f1
PS3, Line 20: No
Does this still take less time than without it with the current CSE?
Hi Subrata,
Yes, as you mentioned we're still sending the command but this UPD is just skipping Hob creation and data copy part. Thus it is resulting in time savings.
I'll check regarding RCR, but yes to skip even sending HECI command, we'll need CSE changes too.
@Tim, Yes it still takes less time since Hob creation is skipped in FSP.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58289
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibb64e4d0f4ae7212defb6704b05a78e754f75cd7
Gerrit-Change-Number: 58289
Gerrit-PatchSet: 3
Gerrit-Owner: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Comment-Date: Mon, 25 Oct 2021 05:28:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Gerrit-MessageType: comment