Attention is currently required from: Robert Zieba, Jon Murphy, Karthik Ramasubramanian, Felix Held.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66761 )
Change subject: util/amdfwtool/amdfwread: List AMDFW RO binary entries
......................................................................
Patch Set 13: Code-Review+2
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/66761/comment/50f9ae3a_5befb0a5
PS13, Line 20: Dir
Ohh, this is pretty
File util/amdfwtool/amdfwread.c:
https://review.coreboot.org/c/coreboot/+/66761/comment/f3e7da0b_b71c48e4
PS12, Line 330: break
This is break for the case statement so that we dont fall-through to the next case.
Yeah.. I forgot how to read C code ;)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/66761
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia1b8f1a2b9bc7dc6925a305cdff1442aaff182cd
Gerrit-Change-Number: 66761
Gerrit-PatchSet: 13
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Robert Zieba
robertzieba@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Robert Zieba
robertzieba@google.com
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 21 Oct 2022 15:14:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment