[M] Change in coreboot[main]: smmstorev2: Load the communication buffer at SMM setup

[Arthur Heymans (Code Review)]

Attention is currently required from: Jérémy Compostella, Patrick Rudolph.

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79738?usp=email )

Change subject: smmstorev2: Load the communication buffer at SMM setup
......................................................................


Patch Set 2:

(3 comments)

File src/cpu/x86/smm/smm_module_loader.c:

https://review.coreboot.org/c/coreboot/+/79738/comment/ad1d9f77_91a32f35 :
PS2, Line 13: #include <stdint.h>
> not needed.
> Done

File src/drivers/smmstore/smi.c:

https://review.coreboot.org/c/coreboot/+/79738/comment/c04e60ed_c5c1896e :
PS1, Line 88: if (base == 0 || size == 0)
            : 			return SMMSTORE_RET_FAILURE;
> This check is not needed as smmstore_init does something similar.
> Done

File src/include/cpu/x86/smm.h:

https://review.coreboot.org/c/coreboot/+/79738/comment/9cf92675_3b0568b7 :
PS2, Line 94: SMMSTORE_V2
> can we get rid of preprocessor guards by using a 0-sized variable when the condition isn't true?

I don't think so. Only the last element can be such an array.



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/79738?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I94dce77711f37f87033530f5ae48cb850a39341b
Gerrit-Change-Number: 79738
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <[e-mail]>
Gerrit-Reviewer: Jérémy Compostella <[e-mail]>
Gerrit-Reviewer: Patrick Rudolph <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Attention: Patrick Rudolph <[e-mail]>
Gerrit-Attention: Jérémy Compostella <[e-mail]>
Gerrit-Comment-Date: Wed, 31 Jan 2024 21:37:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph <[e-mail]>
Comment-In-Reply-To: Arthur Heymans <[e-mail]>
Gerrit-MessageType: comment