Mike Hsieh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32115
Change subject: mb/google/sarien: Make bluetooth reset_gpio active low ......................................................................
mb/google/sarien: Make bluetooth reset_gpio active low
Follow b:129375810 to set bluetooth reset_gpio as ACPI_GPIO_OUTPUT_ACTIVE_LOW
BUG=b:129375810 TEST=Verified BT function on Arcada DVT1 system.
Signed-off-by: Mike Hsieh mike_hsieh@wistron.corp-partner.google.com Change-Id: I816eb2a76f642a2bb1702f38138bce7916334011 --- M src/mainboard/google/sarien/variants/arcada/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/32115/1
diff --git a/src/mainboard/google/sarien/variants/arcada/devicetree.cb b/src/mainboard/google/sarien/variants/arcada/devicetree.cb index 6f167c2..a09d7cb 100644 --- a/src/mainboard/google/sarien/variants/arcada/devicetree.cb +++ b/src/mainboard/google/sarien/variants/arcada/devicetree.cb @@ -261,7 +261,7 @@ chip drivers/usb/acpi register "desc" = ""Bluetooth"" register "type" = "UPC_TYPE_INTERNAL" - register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_H15)" + register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_H15)" device usb 2.9 on end end chip drivers/usb/acpi
Mike Hsieh has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/32115 )
Change subject: mb/google/arcada: Make bluetooth reset_gpio active low ......................................................................
mb/google/arcada: Make bluetooth reset_gpio active low
Follow b:129375810 to set bluetooth reset_gpio as ACPI_GPIO_OUTPUT_ACTIVE_LOW
BUG=b:129375810 TEST=Verified BT function on Arcada DVT1 system.
Signed-off-by: Mike Hsieh mike_hsieh@wistron.corp-partner.google.com Change-Id: I816eb2a76f642a2bb1702f38138bce7916334011 --- M src/mainboard/google/sarien/variants/arcada/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/32115/2
Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32115 )
Change subject: mb/google/arcada: Make bluetooth reset_gpio active low ......................................................................
Patch Set 2: Code-Review+2
Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32115 )
Change subject: mb/google/arcada: Make bluetooth reset_gpio active low ......................................................................
Patch Set 2: Code-Review+2
Duncan Laurie has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32115 )
Change subject: mb/google/arcada: Make bluetooth reset_gpio active low ......................................................................
mb/google/arcada: Make bluetooth reset_gpio active low
Follow b:129375810 to set bluetooth reset_gpio as ACPI_GPIO_OUTPUT_ACTIVE_LOW
BUG=b:129375810 TEST=Verified BT function on Arcada DVT1 system.
Signed-off-by: Mike Hsieh mike_hsieh@wistron.corp-partner.google.com Change-Id: I816eb2a76f642a2bb1702f38138bce7916334011 Reviewed-on: https://review.coreboot.org/c/coreboot/+/32115 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Lijian Zhao lijian.zhao@intel.com Reviewed-by: Duncan Laurie dlaurie@chromium.org --- M src/mainboard/google/sarien/variants/arcada/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Duncan Laurie: Looks good to me, approved Lijian Zhao: Looks good to me, approved
diff --git a/src/mainboard/google/sarien/variants/arcada/devicetree.cb b/src/mainboard/google/sarien/variants/arcada/devicetree.cb index 716fb3f..4bf3736 100644 --- a/src/mainboard/google/sarien/variants/arcada/devicetree.cb +++ b/src/mainboard/google/sarien/variants/arcada/devicetree.cb @@ -261,7 +261,7 @@ chip drivers/usb/acpi register "desc" = ""Bluetooth"" register "type" = "UPC_TYPE_INTERNAL" - register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_H15)" + register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_H15)" device usb 2.9 on end end chip drivers/usb/acpi
-
Duncan Laurie (Code Review) -
Lijian Zhao (Code Review)
-
Mike Hsieh (Code Review)