Attention is currently required from: Ian Feng.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63573 )
Change subject: mb/google/skyrim: Add Goodix touchscreen
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/skyrim/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/63573/comment/20698e7d_e3ad818f
PS2, Line 117: PAD_GPO(GPIO_131, HIGH),
default low, let driver control the power sequence.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63573
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I35dd3ca76e9e0f17508bef46c90b53b4be5d0033
Gerrit-Change-Number: 63573
Gerrit-PatchSet: 2
Gerrit-Owner: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Amanda Hwang
amanda_hwang@compal.corp-partner.google.com
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-CC: Jon Murphy
jpmurphy@google.com
Gerrit-CC: Van Chen
van_chen@compal.corp-partner.google.com
Gerrit-Attention: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-Comment-Date: Mon, 18 Apr 2022 00:11:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment