Change in coreboot[master]: mb/google/brya/var/agah: Add GPU power sequencing - coreboot-gerrit

12 Apr 2022


      Attention is currently required from: Subrata Banik, Angel Pons, Nick Vaccaro.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62384 )
Change subject: mb/google/brya/var/agah: Add GPU power sequencing
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/brya/variants/agah/variant.c:
https://review.coreboot.org/c/coreboot/+/62384/comment/8459003b_eae7063b 
PS1, Line 120: int
...
I think so, but I'm not sure. […]
I believe C in signed-unsigned comparisons, C will convert the signed value to unsigned, hence why I cast the unsigned one.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/62384
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1072be12ef58af5859e2a2d19c4a9c1adc0b0f88
Gerrit-Change-Number: 62384
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik subratabanik@google.com
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Nick Vaccaro nvaccaro@google.com
Gerrit-Comment-Date: Tue, 12 Apr 2022 20:53:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik subratabanik@google.com
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment