Attention is currently required from: Hung-Te Lin, Jarried Lin, Yu-Ping Wu.
Hope Wang has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85127?usp=email )
Change subject: soc/mediatek/mt8196: Add PMIC MT6363 driver ......................................................................
Patch Set 16:
(5 comments)
File src/soc/mediatek/common/include/soc/mt6363.h:
https://review.coreboot.org/c/coreboot/+/85127/comment/182b42ef_0a0821c6?usp... : PS13, Line 114: pmic_lp_setting
remove this if not implemented
Done
File src/soc/mediatek/common/mt6363.c:
https://review.coreboot.org/c/coreboot/+/85127/comment/e7f198f3_2d0ee267?usp... : PS13, Line 29: write
`write8` (because there might be `write16` in the future)
Done
https://review.coreboot.org/c/coreboot/+/85127/comment/d391b3f8_484cd447?usp... : PS13, Line 29: u32
`u8` (because the write function calls `pmif_send_cmd` with `len = 1` in src/soc/mediatek/common/pmi […]
Done
File src/soc/mediatek/mt8196/mt6363.c:
https://review.coreboot.org/c/coreboot/+/85127/comment/61923299_f23396d9?usp... : PS7, Line 13: 0
I meant to remove the `shift` field from the `pmic_setting` struct in the header file.
Done
File src/soc/mediatek/mt8196/mt6363.c:
https://review.coreboot.org/c/coreboot/+/85127/comment/765bb9c1_88c401a6?usp... : PS13, Line 385: /* TODO: Disable unused modem power in a separate function and
Wrong format. […]
Done