Attention is currently required from: Anil Kumar K, Bora Guvendik, Jamie Ryu, Jeremy Compostella, Subrata Banik, Wonkyu Kim.
Pratikkumar V Prajapati has posted comments on this change by Wonkyu Kim. ( https://review.coreboot.org/c/coreboot/+/84228?usp=email )
Change subject: src/device: Add more condition to check valid PCI device id
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84228/comment/2f4fafa5_1641b640?usp... :
PS2, Line 12: Below are invalid PCI device id cases
: VID: 0x0 or 0xffff
: DID: 0x0 or 0xffff
The change is not just WA but also avoiding coreboot's weird behavior. […]
my 2 cents: This patch is just making coreboot more robust. Also this is a simple check, does not create any harm.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84228?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iffabc9037a8af1b2a4ffebdf30199c4f6eae9540
Gerrit-Change-Number: 84228
Gerrit-PatchSet: 2
Gerrit-Owner: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Jeremy Compostella
jeremy.compostella@gmail.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Attention: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Attention: Jeremy Compostella
jeremy.compostella@gmail.com
Gerrit-Comment-Date: Thu, 12 Sep 2024 16:23:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Wonkyu Kim
wonkyu.kim@intel.com