Attention is currently required from: Angel Pons.
Lean Sheng Tan has posted comments on this change by Angel Pons. ( https://review.coreboot.org/c/coreboot/+/74121?usp=email )
Change subject: drivers/option: Add forms in cbtables ......................................................................
Patch Set 30:
(5 comments)
File Documentation/drivers/cfr.md:
https://review.coreboot.org/c/coreboot/+/74121/comment/717cedcf_bddee4e2?usp... : PS29, Line 211: CFR_OPTFLAG_GRAYOUT
to me CFR_OPTFLAG_INACTIVE also sounds better than CFR_OPTFLAG_GRAYOUT
Done here: https://review.coreboot.org/c/coreboot/+/85780
File Documentation/drivers/cfr.md:
https://review.coreboot.org/c/coreboot/+/74121/comment/8fe764e7_c163f03e?usp... : PS30, Line 1: form representation
hmm, didn't we agree in a meeting that we wanted to get rid of this uefi terminology here which is a […]
I think no one bothers to follow up or make new decision, so we decided to get the V1 in with this status quo, if someone wants to change it in future feels free to ;)
https://review.coreboot.org/c/coreboot/+/74121/comment/635d5663_0790b505?usp... : PS30, Line 29: ore
or
https://review.coreboot.org/c/coreboot/+/85780
https://review.coreboot.org/c/coreboot/+/74121/comment/6b917595_b6fb6baf?usp... : PS30, Line 69: immideatly
immediately
https://review.coreboot.org/c/coreboot/+/85780
https://review.coreboot.org/c/coreboot/+/74121/comment/c3eed0fe_9f7c8eea?usp... : PS30, Line 72:
the doc would be slightly easier to read if all tags were first defined and then used. […]
Sorry I dont get it, what do you mean actually?
-
Lean Sheng Tan (Code Review)