Attention is currently required from: Martin L Roth, Lean Sheng Tan.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69202 )
Change subject: lib/ramtest.c: Update ram failure post code
......................................................................
Patch Set 1:
(1 comment)
File src/lib/ramtest.c:
https://review.coreboot.org/c/coreboot/+/69202/comment/d978d13b_ed83a47f
PS1, Line 113: POST_RAM_FAILURE
since we're cleaning this up, any reason not to combine with printk below and use die_with_post_code […]
maybe just for the 2nd one since this is nodie()
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69202
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I21ef196e48ff37ffe320b575d6de66b43997e7eb
Gerrit-Change-Number: 69202
Gerrit-PatchSet: 1
Gerrit-Owner: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Comment-Date: Fri, 04 Nov 2022 22:55:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Gerrit-MessageType: comment