Attention is currently required from: Jason Glenesk, Marshall Dawson, Felix Held.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57068 )
Change subject: soc/amd/common/fsp/fsp_validate: check FSP-M binary size
......................................................................
Patch Set 2:
(1 comment)
File src/soc/amd/common/fsp/fsp_validate.c:
https://review.coreboot.org/c/coreboot/+/57068/comment/484c6852_62544256
PS2, Line 13: "Increase FSP_M_SIZE for it to fit into its memory region.\n");
Can you include the size numbers in the message?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57068
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9b74a2d03993ba50b166eb6e87d4e57b93afc069
Gerrit-Change-Number: 57068
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Sat, 21 Aug 2021 07:30:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment