Attention is currently required from: Alper Nebi Yasak, Philipp Hug, ron minnich.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80372?usp=email )
Change subject: arch/io.h: Add stubs for x86 I/O port functions to other arches
......................................................................
Patch Set 3:
(1 comment)
File src/arch/arm/include/armv7/arch/io.h:
https://review.coreboot.org/c/coreboot/+/80372/comment/588eef61_5a2fb514 :
PS3, Line 17: printk(BIOS_ERR, "arch/io.h: %s() not implemented\n", __func__);
Can we just make these all `die()` if you know that they will never get hit anyway? That would make me more confident that we won't accidentally slip in code that tries to do the wrong thing Arm devices without us noticing at some point.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80372?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If7d9177283e8c692088ba8e30d6dfe52623c8cb9
Gerrit-Change-Number: 80372
Gerrit-PatchSet: 3
Gerrit-Owner: Alper Nebi Yasak
alpernebiyasak@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-Attention: Philipp Hug
philipp@hug.cx
Gerrit-Attention: Alper Nebi Yasak
alpernebiyasak@gmail.com
Gerrit-Attention: ron minnich
rminnich@gmail.com
Gerrit-Comment-Date: Thu, 08 Feb 2024 02:26:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment