Attention is currently required from: Elyes Haouas, Felix Singer, Martin L Roth, Maximilian Brune.
Martin Roth has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/83296?usp=email )
Change subject: Revert "util/crossgcc: Update ACPICA from 20230628 to 20240321"
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
is there a way to compile from git as we do for 3rdparty?
Yes, but we'll have to update the script.
In the meantime, I say we push this revert. It doesn't actually change the version being used because the update didn't actually change the version.
If the tarball on the intel site gets updated to be correct, the build script going to fail because it doesn't match the hash of the incorrect version.
We have the incorrect version on our site as well. So does debian, in their sources, which really surprised me. I would have thought that they'd generate a new tarball based on their own sources, but they just used the one intel released.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83296?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3ce0c5798f14162eaa063a9a64e16e6dbbb9e468
Gerrit-Change-Number: 83296
Gerrit-PatchSet: 3
Gerrit-Owner: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Comment-Date: Wed, 03 Jul 2024 17:45:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth
martin.roth@amd.corp-partner.google.com
Comment-In-Reply-To: Elyes Haouas
ehaouas@noos.fr