Change in coreboot[master]: [TEST] soc/intel/jasperlake: Add debug prints for Slope and Offset
Sumeet R Pawnikar has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48661 )
Change subject: [TEST] soc/intel/jasperlake: Add debug prints for Slope and Offset ......................................................................
[TEST] soc/intel/jasperlake: Add debug prints for Slope and Offset
Add debug prints for Imon Slope and Offset values for FiVR.
Change-Id: I04bf6df711a3cd28b68e0f80bf94ff1f6a6e95a6 Signed-off-by: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com --- M src/soc/intel/jasperlake/fsp_params.c 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/48661/1
diff --git a/src/soc/intel/jasperlake/fsp_params.c b/src/soc/intel/jasperlake/fsp_params.c index c03e9dd..855cfd9 100644 --- a/src/soc/intel/jasperlake/fsp_params.c +++ b/src/soc/intel/jasperlake/fsp_params.c @@ -183,6 +183,9 @@ params->ImonSlope[0] = config->ImonSlope; params->ImonOffset[0] = config->ImonOffset;
+ printk(BIOS_DEBUG, "DEBUG: Imon Slope=%d\n", config->ImonSlope); + printk(BIOS_DEBUG, "DEBUG: Imon Offset=%d\n", config->ImonOffset); + /* SDCard related configuration */ dev = pcidev_path_on_root(PCH_DEVFN_SDCARD); params->ScsSdCardEnabled = is_dev_enabled(dev);
Hello Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48661
to look at the new patch set (#2).
Change subject: [TEST] soc/intel/jasperlake: Add debug prints for Slope and Offset ......................................................................
[TEST] soc/intel/jasperlake: Add debug prints for Slope and Offset
Add debug prints for Imon Slope and Offset values for FiVR.
BUG=none BRANCH=none TEST=Build for dedede
Change-Id: I04bf6df711a3cd28b68e0f80bf94ff1f6a6e95a6 Signed-off-by: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com --- M src/soc/intel/jasperlake/fsp_params.c 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/48661/2
Hello build bot (Jenkins), Maulik V Vaghela, Vidya Gopalakrishnan, Vinay Kumar, Meera Ravindranath, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48661
to look at the new patch set (#3).
Change subject: soc/intel/jasperlake: Add debug prints for Slope and Offset ......................................................................
soc/intel/jasperlake: Add debug prints for Slope and Offset
Add debug prints for Imon Slope and Offset values for FiVR.
BUG=none BRANCH=none TEST=Build for dedede
Change-Id: I04bf6df711a3cd28b68e0f80bf94ff1f6a6e95a6 Signed-off-by: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com --- M src/soc/intel/jasperlake/fsp_params.c 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/48661/3
Vidya Gopalakrishnan has uploaded a new patch set (#4) to the change originally created by Sumeet R Pawnikar. ( https://review.coreboot.org/c/coreboot/+/48661 )
Change subject: soc/intel/jasperlake: Add debug prints for Slope and Offset ......................................................................
soc/intel/jasperlake: Add debug prints for Slope and Offset
Add debug prints for Imon Slope and Offset values for FiVR.
BUG=none BRANCH=none TEST=Build for dedede
Change-Id: I04bf6df711a3cd28b68e0f80bf94ff1f6a6e95a6 Signed-off-by: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com --- M src/soc/intel/jasperlake/fsp_params.c 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/48661/4
Attention is currently required from: Sumeet R Pawnikar, Vidya Gopalakrishnan. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48661 )
Change subject: soc/intel/jasperlake: Add debug prints for Slope and Offset ......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4: Can we not look at the devicetree to identify the values? Are we planning to build any tool that uses these debug statements.
Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/48661?usp=email )
Change subject: soc/intel/jasperlake: Add debug prints for Slope and Offset ......................................................................
Abandoned
This patch has not been touched in over 12 months. Anyone who wants to take over work on this patch, please feel free to restore it and do any work needed to get it merged. If you create a new patch based on this work, please credit the original author.
-
Karthik Ramasubramanian (Code Review) -
Martin L Roth (Code Review)
-
Sumeet R Pawnikar (Code Review)
-
Vidya Gopalakrishnan (Code Review)