Attention is currently required from: Kapil Porwal.
Subrata Banik has posted comments on this change by Kapil Porwal. ( https://review.coreboot.org/c/coreboot/+/83103?usp=email )
Change subject: soc/intel/cmn/block/cse: Create CBMEM entries for payload to fill with CSE info ......................................................................
Patch Set 8:
(1 comment)
File src/soc/intel/common/block/cse/cse_lite.c:
https://review.coreboot.org/c/coreboot/+/83103/comment/83be4aa6_2424c322?usp... : PS8, Line 1555: void *temp = cbmem_add(CBMEM_ID_CSE_INFO, sizeof(struct cse_specific_info)); : if (!temp) : printk(BIOS_ERR, "cse_lite: Couldn't create CBMEM_ID_CSE_INFO\n"); @kapilporwal@google.com i missed this during review. what is the underlying assumption here that we still send CSE basic information cmd even in coreboot (although we select SOC_INTEL_CSE_LITE_SYNC_BY_PAYLOAD) to collect ISH fw information, PSR data, CSE boot partition information etc. That means, we can't get rid of sending HECI cmd from coreboot ?