Attention is currently required from: Sergii Dmytruk, Ron Minnich, Timothy Pearson.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57079 )
Change subject: src/mainboard/emulation/qemu-power9/*: add QEMU POWER9 mainboard
......................................................................
Patch Set 11: Code-Review+1
(2 comments)
File src/mainboard/emulation/qemu-power9/board.fmd:
https://review.coreboot.org/c/coreboot/+/57079/comment/907413e8_8cf63a7b
PS11, Line 12: FLASH@0 CONFIG_ROM_SIZE {
: BIOS@0 CONFIG_ROM_SIZE {
: BOOTBLOCK 128K
: FMAP 0x200
: COREBOOT(CBFS)
: }
: }
This looks identical to util/cbfstool/default.fmd. Use that?
File src/mainboard/emulation/qemu-power9/cbmem.c:
https://review.coreboot.org/c/coreboot/+/57079/comment/7769b1a8_d9973e7c
PS11, Line 9: (1ULL << 32) - 1048576
4ULL * GiB - 1 * MiB
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57079
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I079c5b9ad564024dd13296ef75c263bdc40c9d39
Gerrit-Change-Number: 57079
Gerrit-PatchSet: 11
Gerrit-Owner: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Ron Minnich
rminnich@gmail.com
Gerrit-Reviewer: Timothy Pearson
tpearson@raptorengineering.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Attention: Ron Minnich
rminnich@gmail.com
Gerrit-Attention: Timothy Pearson
tpearson@raptorengineering.com
Gerrit-Comment-Date: Fri, 19 Nov 2021 10:10:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment