Attention is currently required from: Hung-Te Lin, Jarried Lin, Paul Menzel, Xiwen Shao.
Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/84929?usp=email )
Change subject: soc/mediatek/mt8196: Add tracker driver
......................................................................
Patch Set 26: Code-Review+2
(1 comment)
Patchset:
PS26:
```
src/soc/mediatek/mt8196/tracker.c:82:11: error: use of undeclared identifier 'VLP_AO_BASE'; did you mean 'VLPCFG_BASE'?
82 | write32p(VLP_AO_BASE + VLP_CON_AO, val);
| ^~~~~~~~~~~
| VLPCFG_BASE
src/soc/mediatek/mt8196/include/soc/addressmap.h:145:2: note: 'VLPCFG_BASE' declared here
145 | VLPCFG_BASE = IO_PHYS + 0x0C001000,
| ^
1 error generated.
make[2]: *** [Makefile:430: /cb-build/coreboot-gerrit.0/clang-chromeos/GOOGLE_HYLIA/bootblock/soc/mediatek/mt8196/tracker.o] Error 1
make[2]: Leaving directory '/home/coreboot/node-root/workspace/coreboot-gerrit'
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84929?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib9784a370acec45ce36a800f3955b9cf96651298
Gerrit-Change-Number: 84929
Gerrit-PatchSet: 26
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Xiwen Shao
xiwen.shao@mediatek.corp-partner.google.com
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Xiwen Shao
xiwen.shao@mediatek.corp-partner.google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Comment-Date: Sat, 14 Dec 2024 03:16:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes