Attention is currently required from: Shelley Chen, Ravi kumar, mturney mturney, Julius Werner, Rajesh Patil.
Ravi Kumar Bokka has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50581 )
Change subject: src/mainboard/herobrine: Initialize SPI FW for EC and TPM
......................................................................
Patch Set 65:
(1 comment)
File src/mainboard/google/herobrine/Kconfig:
https://review.coreboot.org/c/coreboot/+/50581/comment/97b461df_4d151ce1
PS58, Line 49: config DRIVER_TPM_SPI_BUS
: hex
: default 0xE
:
Just found out that we're going to use the i2c communication lines for TPM, so this should be DRIVER […]
HI Shelly,
We have differentiated TPM GPIO configuration in below gerrit:
https://review.coreboot.org/c/coreboot/+/57186/2
now we squash both changes in single gerrit.
-Ravi
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50581
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8cbdd1d59a0166688d52d61646db1b6764879a7c
Gerrit-Change-Number: 50581
Gerrit-PatchSet: 65
Gerrit-Owner: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Rajesh Patil
rajpat@qualcomm.corp-partner.google.com
Gerrit-CC: Ravi Kumar Bokka
c_rbokka@qualcomm.corp-partner.google.com
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Ravi kumar
rbokka@codeaurora.org
Gerrit-Attention: mturney mturney
mturney@codeaurora.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Rajesh Patil
rajpat@qualcomm.corp-partner.google.com
Gerrit-Comment-Date: Fri, 03 Sep 2021 05:41:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shelley Chen
shchen@google.com
Gerrit-MessageType: comment