Change in coreboot[master]: soc/mediatek: Pass dram info to cbmem - coreboot-gerrit

17 Mar 2022


      Attention is currently required from: Xi Chen, Paul Menzel, Julius Werner, Xixi Chen, Yu-Ping Wu.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61334 )
Change subject: soc/mediatek: Pass dram info to cbmem
......................................................................
Patch Set 22:
(1 comment)
File src/soc/mediatek/common/memory.c:
https://review.coreboot.org/c/coreboot/+/61334/comment/52d079ff_f646a040 
PS22, Line 123: 	p = (void *)((uintptr_t)mc + sizeof(*mc));
...
At the beginning, i got some build error when using "p = &mc->channel[0];". […]
If &mc->channel[0] does not work, what about "p = mc->channel" ?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/61334
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I195187c0c757a43bb6d2c57c8f303249f2a7995a
Gerrit-Change-Number: 61334
Gerrit-PatchSet: 22
Gerrit-Owner: Xixi Chen xixi.chen@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Xi Chen xixi.chen@mediatek.com
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Julius Werner jwerner@chromium.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-CC: Rex-BC Chen rex-bc.chen@mediatek.com
Gerrit-Attention: Xi Chen xixi.chen@mediatek.com
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Julius Werner jwerner@chromium.org
Gerrit-Attention: Xixi Chen xixi.chen@mediatek.corp-partner.google.com
Gerrit-Attention: Yu-Ping Wu yupingso@google.com
Gerrit-Comment-Date: Thu, 17 Mar 2022 04:58:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin hungte@chromium.org
Comment-In-Reply-To: Julius Werner jwerner@chromium.org
Comment-In-Reply-To: Xixi Chen xixi.chen@mediatek.corp-partner.google.com
Comment-In-Reply-To: Yu-Ping Wu yupingso@google.com
Gerrit-MessageType: comment