Attention is currently required from: Felix Singer, Furquan Shaikh, Mariusz Szafrański, Paul Menzel, Subrata Banik, Angel Pons, Michael Niewöhner, Patrick Rudolph, Lance Zhao, Tim Wawrzynczak, Suresh Bellampalli, Vanessa Eusebio, Michal Motyl.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57934 )
Change subject: soc/intel/{common,skl,dnv}: set ACPI_FADT_PLATFORM_CLOCK based on Kconfig
......................................................................
Patch Set 18:
(1 comment)
Patchset:
PS17:
Oh, well, one more thing. […]
So, CB:58085, if put ahead, could make this change consistent I hope. It's
supposed to ensure that the USE_PM_ACPI_TIMER Kconfig is always right
about the state of the timer (before, it just reflected the user choice if
we provided one, and was always disabled if not).
I guess you could even return to PS17.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57934
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id2e5d69b5515c21e6ce922dab2cb88b494c65ebe
Gerrit-Change-Number: 57934
Gerrit-PatchSet: 18
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Mariusz Szafrański
mariuszx.szafranski@intel.com
Gerrit-Reviewer: Michal Motyl
michalx.motyl@intel.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Suresh Bellampalli
suresh.bellampalli@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Mariusz Szafrański
mariuszx.szafranski@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Suresh Bellampalli
suresh.bellampalli@intel.com
Gerrit-Attention: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Attention: Michal Motyl
michalx.motyl@intel.com
Gerrit-Comment-Date: Sat, 02 Oct 2021 11:17:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment