Attention is currently required from: Alexander Couzens, Nicholas Chin, Nicholas Sudsgaard, Nico Huber, Paul Menzel.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80343?usp=email )
Change subject: mainboard/lenovo: Add ThinkCentre M710s (Skylake) ......................................................................
Patch Set 9:
(1 comment)
File src/mainboard/lenovo/thinkcentre_m710s/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/80343/comment/51aeb42c_32fc9ce0 : PS8, Line 19: register "usb2_ports[0]" = "USB2_PORT_MID(OC1)" # USB30A : register "usb2_ports[1]" = "USB2_PORT_MID(OC1)" # USB30B : register "usb2_ports[2]" = "USB2_PORT_MID(OC2)" # F_USB30_1A : register "usb2_ports[3]" = "USB2_PORT_MID(OC2)" # F_USB30_1B : register "usb2_ports[4]" = "USB2_PORT_MID(OC3)" # F_USB30_2A : register "usb2_ports[5]" = "USB2_PORT_MID(OC3)" # F_USB30_2B : register "usb2_ports[6]" = "USB2_PORT_MID(OC_SKIP)" # M.2 Bluetooth : register "usb2_ports[7]" = "USB2_PORT_MID(OC5)" # USB_LANA : register "usb2_ports[8]" = "USB2_PORT_MID(OC5)" # USB_LANB : register "usb2_ports[9]" = "USB2_PORT_MID(OC_SKIP)" # F_USB1 (Pins 5, 7) : register "usb2_ports[10]" = "USB2_PORT_MID(OC_SKIP)" # F_USB1 (Pins 6, 8) : # Used by the SD/MMC reader. :
That is what I originally tried to do. However, I couldn't add comments like that. […]
Sorry, my fault. The content within the quotation marks is C code. So it needs the C style for comments.
Thanks!