Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34808 )
Change subject: cpu/intel: Refactor platform_enter_postcar() ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34808/2/src/cpu/intel/car/romstage.... File src/cpu/intel/car/romstage.c:
https://review.coreboot.org/c/coreboot/+/34808/2/src/cpu/intel/car/romstage.... PS2, Line 69: run_postcar_phase(&early_mtrrs);
That's why postcar as introduced. […]
I can rename it from exit_car.S to something else to indicate it does not teardown CAR, but does the stack change and applies new MTRRs with CD logic. Of course we need to take into account re-entered romstage does not call wbinvd(). But that's all speculation done in different patch trains if/when that can work, I just saw those getting some +1's now, although the performance numbers are not so promising there.
Not a big deal for me to change this as you suggested to get this particular patch forwards.
-
Kyösti Mälkki (Code Review)