[XS] Change in coreboot[main]: src/include/: Introducing a new BIT_32(x) macro. - coreboot-gerrit

2 Sep 2024


      Attention is currently required from: Ashish Kumar Mishra, Martin Roth, Saurabh Mishra, Subrata Banik.
Arthur Heymans has posted comments on this change by Saurabh Mishra. ( https://review.coreboot.org/c/coreboot/+/84142?usp=email )
Change subject: src/include/: Introducing a new BIT_32(x) macro.
......................................................................
Patch Set 7: Code-Review-2
(1 comment)
File src/include/types.h:
https://review.coreboot.org/c/coreboot/+/84142/comment/8deb3f62_b181be62?usp... :
PS5, Line 27:
...
...
I have refactored to tackle above error.
#ifdef BIT_32
#undef BIT_32
#endif
Overriding other code is not the right approach. Simple use a #ifdef without undef?
#ifndef
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/84142?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I70be1ccba59d25af2ba85a2014232072abf2f87d
Gerrit-Change-Number: 84142
Gerrit-PatchSet: 7
Gerrit-Owner: Saurabh Mishra mishra.saurabh@intel.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Anil Kumar K anil.kumar.k@intel.com
Gerrit-CC: Ashish Kumar Mishra ashish.k.mishra@intel.com
Gerrit-CC: Balaji Manigandan balaji.manigandan@intel.com
Gerrit-CC: Bora Guvendik bora.guvendik@intel.com
Gerrit-CC: Hannah Williams hannah.williams@intel.com
Gerrit-CC: Jérémy Compostella jeremy.compostella@intel.com
Gerrit-CC: Krishna P Bhat D krishna.p.bhat.d@intel.com
Gerrit-CC: Martin Roth martin.roth@amd.corp-partner.google.com
Gerrit-CC: Ronak Kanabar ronak.kanabar@intel.com
Gerrit-CC: Sanju Jose Thottan sanjujose.thottan@intel.com
Gerrit-CC: Saurabh Mishra mishra.saurabh@intel.corp-partner.google.com
Gerrit-CC: Wonkyu Kim wonkyu.kim@intel.com
Gerrit-Attention: Saurabh Mishra mishra.saurabh@intel.com
Gerrit-Attention: Ashish Kumar Mishra ashish.k.mishra@intel.com
Gerrit-Attention: Subrata Banik subratabanik@google.com
Gerrit-Attention: Martin Roth martin.roth@amd.corp-partner.google.com
Gerrit-Comment-Date: Mon, 02 Sep 2024 08:32:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Saurabh Mishra mishra.saurabh@intel.com
Comment-In-Reply-To: Subrata Banik subratabanik@google.com
Comment-In-Reply-To: Arthur Heymans arthur@aheymans.xyz