Attention is currently required from: John Su, Ricky Chang.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62638 )
Change subject: mb/google/brya/variants/felwinter: Fixed stylus UI behavior bug
......................................................................
Patch Set 1:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62638/comment/67be5407_8f04b4ea
PS1, Line 7: Fixed
Imperative mood: Fix
https://review.coreboot.org/c/coreboot/+/62638/comment/cd9e6a1c_d01c6b38
PS1, Line 9: Fixed
Fix
https://review.coreboot.org/c/coreboot/+/62638/comment/fc131d78_bffa2b2d
PS1, Line 10: Configuring
Configure
https://review.coreboot.org/c/coreboot/+/62638/comment/5820eb32_25c3cc50
PS1, Line 10: - Configuring GPP_A7 as "ACPI_GPIO_INPUT_ACTIVE_LOW".
: - Change wakeup_event_action from ASSERTED to DEASSERTED.
Why? What is the source?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62638
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6f5e2992584d759eb1a559684d1cda08c7cbe3f2
Gerrit-Change-Number: 62638
Gerrit-PatchSet: 1
Gerrit-Owner: John Su
john_su@compal.corp-partner.google.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Ricky Chang
rickytlchang@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Amanda Hwang
amanda_hwang@compal.corp-partner.google.com
Gerrit-CC: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-CC: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-CC: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Van Chen
van_chen@compal.corp-partner.google.com
Gerrit-Attention: John Su
john_su@compal.corp-partner.google.com
Gerrit-Attention: Ricky Chang
rickytlchang@google.com
Gerrit-Comment-Date: Mon, 07 Mar 2022 22:05:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment