HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36306 )
Change subject: mb/gigabyte: Use 'Device()' instead of 'Processor()' ......................................................................
mb/gigabyte: Use 'Device()' instead of 'Processor()'
Processor() operator is deprecated, use Device() instead.
Change-Id: Ia27308ba17c6b5c836ada6278f7d26631e09c022 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/gigabyte/ma785gm/acpi/cpstate.asl M src/mainboard/gigabyte/ma785gm/dsdt.asl M src/mainboard/gigabyte/ma785gmt/acpi/cpstate.asl M src/mainboard/gigabyte/ma785gmt/dsdt.asl M src/mainboard/gigabyte/ma78gm/acpi/cpstate.asl M src/mainboard/gigabyte/ma78gm/dsdt.asl 6 files changed, 72 insertions(+), 93 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/36306/1
diff --git a/src/mainboard/gigabyte/ma785gm/acpi/cpstate.asl b/src/mainboard/gigabyte/ma785gm/acpi/cpstate.asl index 206dd68..6fe536a 100644 --- a/src/mainboard/gigabyte/ma785gm/acpi/cpstate.asl +++ b/src/mainboard/gigabyte/ma785gm/acpi/cpstate.asl @@ -23,16 +23,24 @@ DefinitionBlock ("DSDT.AML", "DSDT", 0x01, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001) { Scope (_PR) { - Processor(CPU0,0,0x808,0x06) { + Device (CPU0) { + Name (_HID, "ACPI0007") + Name (_UID, 0) #include "cpstate.asl" } - Processor(CPU1,1,0x0,0x0) { + Device (CPU1) { + Name (_HID, "ACPI0007") + Name (_UID, 1) #include "cpstate.asl" } - Processor(CPU2,2,0x0,0x0) { + Device (CPU2) { + Name (_HID, "ACPI0007") + Name (_UID, 2) #include "cpstate.asl" } - Processor(CPU3,3,0x0,0x0) { + Device (CPU3) { + Name (_HID, "ACPI0007") + Name (_UID, 3) #include "cpstate.asl" } } diff --git a/src/mainboard/gigabyte/ma785gm/dsdt.asl b/src/mainboard/gigabyte/ma785gm/dsdt.asl index 3059be9..eec3093 100644 --- a/src/mainboard/gigabyte/ma785gm/dsdt.asl +++ b/src/mainboard/gigabyte/ma785gm/dsdt.asl @@ -58,39 +58,24 @@ * */ Scope (_PR) { /* define processor scope */ - Processor( - CPU0, /* name space name */ - 0, /* Unique number for this processor */ - 0x808, /* PBLK system I/O address !hardcoded! */ - 0x06 /* PBLKLEN for boot processor */ - ) { + Device (CPU0) { + Name (_HID, "ACPI0007") + Name (_UID, 0) #include "acpi/cpstate.asl" } - - Processor( - CPU1, /* name space name */ - 1, /* Unique number for this processor */ - 0x0000, /* PBLK system I/O address !hardcoded! */ - 0x00 /* PBLKLEN for boot processor */ - ) { + Device (CPU1) { + Name (_HID, "ACPI0007") + Name (_UID, 1) #include "acpi/cpstate.asl" } - - Processor( - CPU2, /* name space name */ - 2, /* Unique number for this processor */ - 0x0000, /* PBLK system I/O address !hardcoded! */ - 0x00 /* PBLKLEN for boot processor */ - ) { + Device (CPU2) { + Name (_HID, "ACPI0007") + Name (_UID, 2) #include "acpi/cpstate.asl" } - - Processor( - CPU3, /* name space name */ - 3, /* Unique number for this processor */ - 0x0000, /* PBLK system I/O address !hardcoded! */ - 0x00 /* PBLKLEN for boot processor */ - ) { + Device (CPU3) { + Name (_HID, "ACPI0007") + Name (_UID, 3) #include "acpi/cpstate.asl" } } /* End _PR scope */ diff --git a/src/mainboard/gigabyte/ma785gmt/acpi/cpstate.asl b/src/mainboard/gigabyte/ma785gmt/acpi/cpstate.asl index 206dd68..6fe536a 100644 --- a/src/mainboard/gigabyte/ma785gmt/acpi/cpstate.asl +++ b/src/mainboard/gigabyte/ma785gmt/acpi/cpstate.asl @@ -23,16 +23,24 @@ DefinitionBlock ("DSDT.AML", "DSDT", 0x01, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001) { Scope (_PR) { - Processor(CPU0,0,0x808,0x06) { + Device (CPU0) { + Name (_HID, "ACPI0007") + Name (_UID, 0) #include "cpstate.asl" } - Processor(CPU1,1,0x0,0x0) { + Device (CPU1) { + Name (_HID, "ACPI0007") + Name (_UID, 1) #include "cpstate.asl" } - Processor(CPU2,2,0x0,0x0) { + Device (CPU2) { + Name (_HID, "ACPI0007") + Name (_UID, 2) #include "cpstate.asl" } - Processor(CPU3,3,0x0,0x0) { + Device (CPU3) { + Name (_HID, "ACPI0007") + Name (_UID, 3) #include "cpstate.asl" } } diff --git a/src/mainboard/gigabyte/ma785gmt/dsdt.asl b/src/mainboard/gigabyte/ma785gmt/dsdt.asl index 3059be9..eec3093 100644 --- a/src/mainboard/gigabyte/ma785gmt/dsdt.asl +++ b/src/mainboard/gigabyte/ma785gmt/dsdt.asl @@ -58,39 +58,24 @@ * */ Scope (_PR) { /* define processor scope */ - Processor( - CPU0, /* name space name */ - 0, /* Unique number for this processor */ - 0x808, /* PBLK system I/O address !hardcoded! */ - 0x06 /* PBLKLEN for boot processor */ - ) { + Device (CPU0) { + Name (_HID, "ACPI0007") + Name (_UID, 0) #include "acpi/cpstate.asl" } - - Processor( - CPU1, /* name space name */ - 1, /* Unique number for this processor */ - 0x0000, /* PBLK system I/O address !hardcoded! */ - 0x00 /* PBLKLEN for boot processor */ - ) { + Device (CPU1) { + Name (_HID, "ACPI0007") + Name (_UID, 1) #include "acpi/cpstate.asl" } - - Processor( - CPU2, /* name space name */ - 2, /* Unique number for this processor */ - 0x0000, /* PBLK system I/O address !hardcoded! */ - 0x00 /* PBLKLEN for boot processor */ - ) { + Device (CPU2) { + Name (_HID, "ACPI0007") + Name (_UID, 2) #include "acpi/cpstate.asl" } - - Processor( - CPU3, /* name space name */ - 3, /* Unique number for this processor */ - 0x0000, /* PBLK system I/O address !hardcoded! */ - 0x00 /* PBLKLEN for boot processor */ - ) { + Device (CPU3) { + Name (_HID, "ACPI0007") + Name (_UID, 3) #include "acpi/cpstate.asl" } } /* End _PR scope */ diff --git a/src/mainboard/gigabyte/ma78gm/acpi/cpstate.asl b/src/mainboard/gigabyte/ma78gm/acpi/cpstate.asl index 206dd68..6fe536a 100644 --- a/src/mainboard/gigabyte/ma78gm/acpi/cpstate.asl +++ b/src/mainboard/gigabyte/ma78gm/acpi/cpstate.asl @@ -23,16 +23,24 @@ DefinitionBlock ("DSDT.AML", "DSDT", 0x01, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001) { Scope (_PR) { - Processor(CPU0,0,0x808,0x06) { + Device (CPU0) { + Name (_HID, "ACPI0007") + Name (_UID, 0) #include "cpstate.asl" } - Processor(CPU1,1,0x0,0x0) { + Device (CPU1) { + Name (_HID, "ACPI0007") + Name (_UID, 1) #include "cpstate.asl" } - Processor(CPU2,2,0x0,0x0) { + Device (CPU2) { + Name (_HID, "ACPI0007") + Name (_UID, 2) #include "cpstate.asl" } - Processor(CPU3,3,0x0,0x0) { + Device (CPU3) { + Name (_HID, "ACPI0007") + Name (_UID, 3) #include "cpstate.asl" } } diff --git a/src/mainboard/gigabyte/ma78gm/dsdt.asl b/src/mainboard/gigabyte/ma78gm/dsdt.asl index 3059be9..eec3093 100644 --- a/src/mainboard/gigabyte/ma78gm/dsdt.asl +++ b/src/mainboard/gigabyte/ma78gm/dsdt.asl @@ -58,39 +58,24 @@ * */ Scope (_PR) { /* define processor scope */ - Processor( - CPU0, /* name space name */ - 0, /* Unique number for this processor */ - 0x808, /* PBLK system I/O address !hardcoded! */ - 0x06 /* PBLKLEN for boot processor */ - ) { + Device (CPU0) { + Name (_HID, "ACPI0007") + Name (_UID, 0) #include "acpi/cpstate.asl" } - - Processor( - CPU1, /* name space name */ - 1, /* Unique number for this processor */ - 0x0000, /* PBLK system I/O address !hardcoded! */ - 0x00 /* PBLKLEN for boot processor */ - ) { + Device (CPU1) { + Name (_HID, "ACPI0007") + Name (_UID, 1) #include "acpi/cpstate.asl" } - - Processor( - CPU2, /* name space name */ - 2, /* Unique number for this processor */ - 0x0000, /* PBLK system I/O address !hardcoded! */ - 0x00 /* PBLKLEN for boot processor */ - ) { + Device (CPU2) { + Name (_HID, "ACPI0007") + Name (_UID, 2) #include "acpi/cpstate.asl" } - - Processor( - CPU3, /* name space name */ - 3, /* Unique number for this processor */ - 0x0000, /* PBLK system I/O address !hardcoded! */ - 0x00 /* PBLKLEN for boot processor */ - ) { + Device (CPU3) { + Name (_HID, "ACPI0007") + Name (_UID, 3) #include "acpi/cpstate.asl" } } /* End _PR scope */
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36306
to look at the new patch set (#2).
Change subject: mb/gigabyte: Use 'Device()' instead of 'Processor()' ......................................................................
mb/gigabyte: Use 'Device()' instead of 'Processor()'
Processor() operator is deprecated, use Device() instead.
Change-Id: Ia27308ba17c6b5c836ada6278f7d26631e09c022 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/gigabyte/ma785gm/acpi/cpstate.asl M src/mainboard/gigabyte/ma785gm/dsdt.asl M src/mainboard/gigabyte/ma785gmt/acpi/cpstate.asl M src/mainboard/gigabyte/ma785gmt/dsdt.asl M src/mainboard/gigabyte/ma78gm/acpi/cpstate.asl M src/mainboard/gigabyte/ma78gm/dsdt.asl 6 files changed, 76 insertions(+), 97 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/36306/2
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36306 )
Change subject: mb/gigabyte: Use 'Device()' instead of 'Processor()' ......................................................................
Patch Set 2: Code-Review+2
Martin Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36306 )
Change subject: mb/gigabyte: Use 'Device()' instead of 'Processor()' ......................................................................
mb/gigabyte: Use 'Device()' instead of 'Processor()'
Processor() operator is deprecated, use Device() instead.
Change-Id: Ia27308ba17c6b5c836ada6278f7d26631e09c022 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/36306 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Martin Roth martinroth@google.com --- M src/mainboard/gigabyte/ma785gm/acpi/cpstate.asl M src/mainboard/gigabyte/ma785gm/dsdt.asl M src/mainboard/gigabyte/ma785gmt/acpi/cpstate.asl M src/mainboard/gigabyte/ma785gmt/dsdt.asl M src/mainboard/gigabyte/ma78gm/acpi/cpstate.asl M src/mainboard/gigabyte/ma78gm/dsdt.asl 6 files changed, 76 insertions(+), 97 deletions(-)
Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved
diff --git a/src/mainboard/gigabyte/ma785gm/acpi/cpstate.asl b/src/mainboard/gigabyte/ma785gm/acpi/cpstate.asl index 206dd68..acaa5ba 100644 --- a/src/mainboard/gigabyte/ma785gm/acpi/cpstate.asl +++ b/src/mainboard/gigabyte/ma785gm/acpi/cpstate.asl @@ -22,17 +22,25 @@ #include <arch/acpi.h> DefinitionBlock ("DSDT.AML", "DSDT", 0x01, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001) { - Scope (_PR) { - Processor(CPU0,0,0x808,0x06) { + Scope (_PR) { + Device (CPU0) { + Name (_HID, "ACPI0007") + Name (_UID, 0) #include "cpstate.asl" } - Processor(CPU1,1,0x0,0x0) { + Device (CPU1) { + Name (_HID, "ACPI0007") + Name (_UID, 1) #include "cpstate.asl" } - Processor(CPU2,2,0x0,0x0) { + Device (CPU2) { + Name (_HID, "ACPI0007") + Name (_UID, 2) #include "cpstate.asl" } - Processor(CPU3,3,0x0,0x0) { + Device (CPU3) { + Name (_HID, "ACPI0007") + Name (_UID, 3) #include "cpstate.asl" } } diff --git a/src/mainboard/gigabyte/ma785gm/dsdt.asl b/src/mainboard/gigabyte/ma785gm/dsdt.asl index 3059be9..eec3093 100644 --- a/src/mainboard/gigabyte/ma785gm/dsdt.asl +++ b/src/mainboard/gigabyte/ma785gm/dsdt.asl @@ -58,39 +58,24 @@ * */ Scope (_PR) { /* define processor scope */ - Processor( - CPU0, /* name space name */ - 0, /* Unique number for this processor */ - 0x808, /* PBLK system I/O address !hardcoded! */ - 0x06 /* PBLKLEN for boot processor */ - ) { + Device (CPU0) { + Name (_HID, "ACPI0007") + Name (_UID, 0) #include "acpi/cpstate.asl" } - - Processor( - CPU1, /* name space name */ - 1, /* Unique number for this processor */ - 0x0000, /* PBLK system I/O address !hardcoded! */ - 0x00 /* PBLKLEN for boot processor */ - ) { + Device (CPU1) { + Name (_HID, "ACPI0007") + Name (_UID, 1) #include "acpi/cpstate.asl" } - - Processor( - CPU2, /* name space name */ - 2, /* Unique number for this processor */ - 0x0000, /* PBLK system I/O address !hardcoded! */ - 0x00 /* PBLKLEN for boot processor */ - ) { + Device (CPU2) { + Name (_HID, "ACPI0007") + Name (_UID, 2) #include "acpi/cpstate.asl" } - - Processor( - CPU3, /* name space name */ - 3, /* Unique number for this processor */ - 0x0000, /* PBLK system I/O address !hardcoded! */ - 0x00 /* PBLKLEN for boot processor */ - ) { + Device (CPU3) { + Name (_HID, "ACPI0007") + Name (_UID, 3) #include "acpi/cpstate.asl" } } /* End _PR scope */ diff --git a/src/mainboard/gigabyte/ma785gmt/acpi/cpstate.asl b/src/mainboard/gigabyte/ma785gmt/acpi/cpstate.asl index 206dd68..af0092a 100644 --- a/src/mainboard/gigabyte/ma785gmt/acpi/cpstate.asl +++ b/src/mainboard/gigabyte/ma785gmt/acpi/cpstate.asl @@ -16,23 +16,31 @@ /* This file defines the processor and performance state capability * for each core in the system. It is included into the DSDT for each * core. It assumes that each core of the system has the same performance - * characteristics. + * charateristics. */ /* #include <arch/acpi.h> DefinitionBlock ("DSDT.AML", "DSDT", 0x01, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001) { - Scope (_PR) { - Processor(CPU0,0,0x808,0x06) { + Scope (_PR) { + Device (CPU0) { + Name (_HID, "ACPI0007") + Name (_UID, 0) #include "cpstate.asl" } - Processor(CPU1,1,0x0,0x0) { + Device (CPU1) { + Name (_HID, "ACPI0007") + Name (_UID, 1) #include "cpstate.asl" } - Processor(CPU2,2,0x0,0x0) { + Device (CPU2) { + Name (_HID, "ACPI0007") + Name (_UID, 2) #include "cpstate.asl" } - Processor(CPU3,3,0x0,0x0) { + Device (CPU3) { + Name (_HID, "ACPI0007") + Name (_UID, 3) #include "cpstate.asl" } } diff --git a/src/mainboard/gigabyte/ma785gmt/dsdt.asl b/src/mainboard/gigabyte/ma785gmt/dsdt.asl index 3059be9..eec3093 100644 --- a/src/mainboard/gigabyte/ma785gmt/dsdt.asl +++ b/src/mainboard/gigabyte/ma785gmt/dsdt.asl @@ -58,39 +58,24 @@ * */ Scope (_PR) { /* define processor scope */ - Processor( - CPU0, /* name space name */ - 0, /* Unique number for this processor */ - 0x808, /* PBLK system I/O address !hardcoded! */ - 0x06 /* PBLKLEN for boot processor */ - ) { + Device (CPU0) { + Name (_HID, "ACPI0007") + Name (_UID, 0) #include "acpi/cpstate.asl" } - - Processor( - CPU1, /* name space name */ - 1, /* Unique number for this processor */ - 0x0000, /* PBLK system I/O address !hardcoded! */ - 0x00 /* PBLKLEN for boot processor */ - ) { + Device (CPU1) { + Name (_HID, "ACPI0007") + Name (_UID, 1) #include "acpi/cpstate.asl" } - - Processor( - CPU2, /* name space name */ - 2, /* Unique number for this processor */ - 0x0000, /* PBLK system I/O address !hardcoded! */ - 0x00 /* PBLKLEN for boot processor */ - ) { + Device (CPU2) { + Name (_HID, "ACPI0007") + Name (_UID, 2) #include "acpi/cpstate.asl" } - - Processor( - CPU3, /* name space name */ - 3, /* Unique number for this processor */ - 0x0000, /* PBLK system I/O address !hardcoded! */ - 0x00 /* PBLKLEN for boot processor */ - ) { + Device (CPU3) { + Name (_HID, "ACPI0007") + Name (_UID, 3) #include "acpi/cpstate.asl" } } /* End _PR scope */ diff --git a/src/mainboard/gigabyte/ma78gm/acpi/cpstate.asl b/src/mainboard/gigabyte/ma78gm/acpi/cpstate.asl index 206dd68..acaa5ba 100644 --- a/src/mainboard/gigabyte/ma78gm/acpi/cpstate.asl +++ b/src/mainboard/gigabyte/ma78gm/acpi/cpstate.asl @@ -22,17 +22,25 @@ #include <arch/acpi.h> DefinitionBlock ("DSDT.AML", "DSDT", 0x01, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001) { - Scope (_PR) { - Processor(CPU0,0,0x808,0x06) { + Scope (_PR) { + Device (CPU0) { + Name (_HID, "ACPI0007") + Name (_UID, 0) #include "cpstate.asl" } - Processor(CPU1,1,0x0,0x0) { + Device (CPU1) { + Name (_HID, "ACPI0007") + Name (_UID, 1) #include "cpstate.asl" } - Processor(CPU2,2,0x0,0x0) { + Device (CPU2) { + Name (_HID, "ACPI0007") + Name (_UID, 2) #include "cpstate.asl" } - Processor(CPU3,3,0x0,0x0) { + Device (CPU3) { + Name (_HID, "ACPI0007") + Name (_UID, 3) #include "cpstate.asl" } } diff --git a/src/mainboard/gigabyte/ma78gm/dsdt.asl b/src/mainboard/gigabyte/ma78gm/dsdt.asl index 3059be9..eec3093 100644 --- a/src/mainboard/gigabyte/ma78gm/dsdt.asl +++ b/src/mainboard/gigabyte/ma78gm/dsdt.asl @@ -58,39 +58,24 @@ * */ Scope (_PR) { /* define processor scope */ - Processor( - CPU0, /* name space name */ - 0, /* Unique number for this processor */ - 0x808, /* PBLK system I/O address !hardcoded! */ - 0x06 /* PBLKLEN for boot processor */ - ) { + Device (CPU0) { + Name (_HID, "ACPI0007") + Name (_UID, 0) #include "acpi/cpstate.asl" } - - Processor( - CPU1, /* name space name */ - 1, /* Unique number for this processor */ - 0x0000, /* PBLK system I/O address !hardcoded! */ - 0x00 /* PBLKLEN for boot processor */ - ) { + Device (CPU1) { + Name (_HID, "ACPI0007") + Name (_UID, 1) #include "acpi/cpstate.asl" } - - Processor( - CPU2, /* name space name */ - 2, /* Unique number for this processor */ - 0x0000, /* PBLK system I/O address !hardcoded! */ - 0x00 /* PBLKLEN for boot processor */ - ) { + Device (CPU2) { + Name (_HID, "ACPI0007") + Name (_UID, 2) #include "acpi/cpstate.asl" } - - Processor( - CPU3, /* name space name */ - 3, /* Unique number for this processor */ - 0x0000, /* PBLK system I/O address !hardcoded! */ - 0x00 /* PBLKLEN for boot processor */ - ) { + Device (CPU3) { + Name (_HID, "ACPI0007") + Name (_UID, 3) #include "acpi/cpstate.asl" } } /* End _PR scope */
-
HAOUAS Elyes (Code Review) -
Martin Roth (Code Review)