Change in coreboot[master]: mb/qemu/fw_cfg: Add info messages about (un)found files

[Nico Huber (Code Review)]

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43444 )

Change subject: mb/qemu/fw_cfg: Add info messages about (un)found files
......................................................................

mb/qemu/fw_cfg: Add info messages about (un)found files

Change-Id: I1431d569c57634277ea5cf7feb352419db432b44
Signed-off-by: Nico Huber 
---
M src/mainboard/emulation/qemu-i440fx/fw_cfg.c
1 file changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/43444/1

diff --git a/src/mainboard/emulation/qemu-i440fx/fw_cfg.c b/src/mainboard/emulation/qemu-i440fx/fw_cfg.c
index 536e775..6ee6863 100644
--- a/src/mainboard/emulation/qemu-i440fx/fw_cfg.c
+++ b/src/mainboard/emulation/qemu-i440fx/fw_cfg.c
@@ -74,9 +74,11 @@
    	if (strcmp(file->name, name) == 0) {
    		file->size = be32_to_cpu(file->size);
    		file->select = be16_to_cpu(file->select);
+			printk(BIOS_INFO, "QEMU: firmware config: Found '%s'\n", name);
    		return 0;
    	}
    }
+	printk(BIOS_INFO, "QEMU: firmware config: Couldn't find '%s'\n", name);
    return -1;
 }

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43444 )

Change subject: mb/qemu/fw_cfg: Add info messages about (un)found files
......................................................................

Patch Set 1: Code-Review+1

(2 comments)

https://review.coreboot.org/c/coreboot/+/43444/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/43444/1//COMMIT_MSG@7 
PS1, Line 7: un
not

https://review.coreboot.org/c/coreboot/+/43444/1//COMMIT_MSG@8 
PS1, Line 8: 
What's the rationale behind this change?

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43444 )

Change subject: mb/qemu/fw_cfg: Add info messages about (un)found files
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43444/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/43444/1//COMMIT_MSG@8 
PS1, Line 8:
> What's the rationale behind this change?

Ack

Change in coreboot[master]: mb/qemu/fw_cfg: Add info messages about (not) found files

[Nico Huber (Code Review)]

Hello build bot (Jenkins), Angel Pons,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43444

to look at the new patch set (#2).

Change subject: mb/qemu/fw_cfg: Add info messages about (not) found files
......................................................................

mb/qemu/fw_cfg: Add info messages about (not) found files

Print some more information at BIOS_INFO, like our CBFS code does.

Change-Id: I1431d569c57634277ea5cf7feb352419db432b44
Signed-off-by: Nico Huber 
---
M src/mainboard/emulation/qemu-i440fx/fw_cfg.c
1 file changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/43444/2

Change in coreboot[master]: mb/qemu/fw_cfg: Add info messages about (not) found files

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43444 )

Change subject: mb/qemu/fw_cfg: Add info messages about (not) found files
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43444/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/43444/1//COMMIT_MSG@7 
PS1, Line 7: un
> not

Done

Change in coreboot[master]: mb/qemu/fw_cfg: Add info messages about (not) found files

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43444 )

Change subject: mb/qemu/fw_cfg: Add info messages about (not) found files
......................................................................

Patch Set 2: Code-Review+2

Change in coreboot[master]: mb/qemu/fw_cfg: Add info messages about (not) found files

[Nico Huber (Code Review)]

Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43444 )

Change subject: mb/qemu/fw_cfg: Add info messages about (not) found files
......................................................................

mb/qemu/fw_cfg: Add info messages about (not) found files

Print some more information at BIOS_INFO, like our CBFS code does.

Change-Id: I1431d569c57634277ea5cf7feb352419db432b44
Signed-off-by: Nico Huber 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/43444
Reviewed-by: Angel Pons 
Tested-by: build bot (Jenkins) 
---
M src/mainboard/emulation/qemu-i440fx/fw_cfg.c
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Angel Pons: Looks good to me, approved

diff --git a/src/mainboard/emulation/qemu-i440fx/fw_cfg.c b/src/mainboard/emulation/qemu-i440fx/fw_cfg.c
index 536e775..6ee6863 100644
--- a/src/mainboard/emulation/qemu-i440fx/fw_cfg.c
+++ b/src/mainboard/emulation/qemu-i440fx/fw_cfg.c
@@ -74,9 +74,11 @@
    	if (strcmp(file->name, name) == 0) {
    		file->size = be32_to_cpu(file->size);
    		file->select = be16_to_cpu(file->select);
+			printk(BIOS_INFO, "QEMU: firmware config: Found '%s'\n", name);
    		return 0;
    	}
    }
+	printk(BIOS_INFO, "QEMU: firmware config: Couldn't find '%s'\n", name);
    return -1;
 }