Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31930 )
Change subject: mb/*/chromeos.c: Be explicit about code for ramstage ......................................................................
Patch Set 1: Code-Review+2
We currently define pci_config_read/writeX() differently for ramstage. I am working on to get rid of this __SIMPLE_DEVICE__ nuicance.
Oh okay... that's unfortunate. In that case wouldn't the cleanest thing be to use the same differentiator that the definition of those functions uses (i.e. #ifdef __SIMPLE_DEVICE__)? Although I guess that might make it harder if you want to get rid of those. I guess I don't really care.
You could still remove it from Beltino and Jecht, though, those don't seem to use those functions.
-
Julius Werner (Code Review)