Change in coreboot[master]: ec/starlabs: Store the correct value for KLSE when suspending

[Felix Held (Code Review)]

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/62605 )

Change subject: ec/starlabs: Store the correct value for KLSE when suspending
......................................................................

ec/starlabs: Store the correct value for KLSE when suspending

The current code will read the raw value from the EC, which doesn't
match the respective setting in CMOS.

Switch argument will store the correct value.

Signed-off-by: Sean Rhodes 
Change-Id: I62e0fc3b6fcae72f2d8eacf37a390b4e4b1f0783
Reviewed-on: https://review.coreboot.org/c/coreboot/+/62605
Reviewed-by: Angel Pons 
Tested-by: build bot (Jenkins) 
---
M src/ec/starlabs/merlin/acpi/suspend.asl
1 file changed, 15 insertions(+), 2 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Angel Pons: Looks good to me, approved

diff --git a/src/ec/starlabs/merlin/acpi/suspend.asl b/src/ec/starlabs/merlin/acpi/suspend.asl
index 9f88a05..a753ba6 100644
--- a/src/ec/starlabs/merlin/acpi/suspend.asl
+++ b/src/ec/starlabs/merlin/acpi/suspend.asl
@@ -26,8 +26,21 @@

_SB.PCI0.LPCB.FLKC =
    		_SB.PCI0.LPCB.EC.ECRD (RefOf (_SB.PCI0.LPCB.EC.FLKE))
-		_SB.PCI0.LPCB.KLSC =
-			_SB.PCI0.LPCB.EC.ECRD (RefOf (_SB.PCI0.LPCB.EC.KLSE))
+
+		Switch (ToInteger (_SB.PCI0.LPCB.EC.ECRD (RefOf (_SB.PCI0.LPCB.EC.KLSE))))
+		{
+			// 0x00 == Disabled == 0x00
+			// 0xdd == Enabled  == 0x01
+			Case (0x00)
+			{
+				_SB.PCI0.LPCB.KLSC = 0x00
+			}
+			Case (0xdd)
+			{
+				_SB.PCI0.LPCB.KLSC = 0x01
+			}
+		}
+
    	_SB.PCI0.LPCB.KLBC =
    		_SB.PCI0.LPCB.EC.ECRD (RefOf (_SB.PCI0.LPCB.EC.KLBE))
    }