Attention is currently required from: Arthur Heymans, Nico Huber.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80465?usp=email )
Change subject: [UNTESTED]nb/intel/gm45: Use ssdt PCI root bridge generator
......................................................................
Patch Set 3:
(1 comment)
File src/northbridge/intel/gm45/northbridge.c:
https://review.coreboot.org/c/coreboot/+/80465/comment/fcd384ee_deb23a4f :
PS3, Line 111: struct resource *upper_pci = find_resource(dev, IOINDEX_SUBTRACTIVE(2, 0));
: if (upper_pci)
: upper_pci->base = touud;
:
: struct resource *lower_pci = find_resource(dev, IOINDEX_SUBTRACTIVE(1, 0));
: if (lower_pci)
: lower_pci->base = tolud;
i'd also prefer to just report the correct resources. […]
sounds good to me
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80465?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic558359101c59d6137a0abb460d19feeda36c6dc
Gerrit-Change-Number: 80465
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Tue, 13 Feb 2024 17:43:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment