[M] Change in coreboot[main]: driver/amd/opensil: Add PHX OpenSIL POC TP2/TP3 calls

[Marshall Dawson (Code Review)]

Attention is currently required from: Ana Carolina Cabral, Felix Held, Fred Reitberger, Jason Glenesk, Martin Roth, Matt DeVillier, Matt DeVillier, Nick Kochlowski, Paul Menzel.

Marshall Dawson has posted comments on this change by Nick Kochlowski. ( https://review.coreboot.org/c/coreboot/+/84915?usp=email )

Change subject: driver/amd/opensil: Add PHX OpenSIL POC TP2/TP3 calls
......................................................................

Patch Set 9:

(2 comments)

File src/drivers/amd/opensil/amd_silicon_init.c:

https://review.coreboot.org/c/coreboot/+/84915/comment/6a3f0e88_74e4c43d?usp... :
PS8, Line 29: BOOT_STATE_INIT_ENTRY(BS_DEV_RESOURCES, BS_ON_EXIT, call_opensil_xSIM_timepoint, (void *)XSIM_TIMEPOINT_2);
            : BOOT_STATE_INIT_ENTRY(BS_PAYLOAD_LOAD, BS_ON_EXIT, call_opensil_xSIM_timepoint, (void *)XSIM_TIMEPOINT_3);
            : BOOT_STATE_INIT_ENTRY(BS_OS_RESUME, BS_ON_ENTRY, call_opensil_xSIM_timepoint, (void *)XSIM_TIMEPOINT_3);
> Do these TP2/TP3 calls need to be conditioned to execute only when PHX is selected? Or will this be  […]

They'll be common to all

File src/drivers/amd/opensil/amd_silicon_init.c:

https://review.coreboot.org/c/coreboot/+/84915/comment/131051e6_d807881f?usp... :
PS9, Line 30: call_opensil_xSIM_timepoint,
            : 	(void *)(uintptr_t)XSIM_TIMEPOINT_2);
Just a nit on style, I'd put these arguments on the same line vs. having 2 linebreaks in the statement.  Same below too.