Attention is currently required from: Jason Glenesk, Raul Rangel, Martin Roth, Marshall Dawson. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52763 )
Change subject: soc/amd/common: Add placeholder GPIO macro, PAD_UNCHANGED ......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52763/comment/4d58c5fa_afc4a724 PS1, Line 9: GPIOs can only be updated in gpio_configure_pads_with_override() if they : are present in the base table. If they are not there, the override : does not work. This allows them to be in the base table so that they can : be overridden without changing the existing configuration.
have a look at CB:43050 that might be the proper fix instead of this workaround. […]
talked with Martin and the scopes of those two things are a bit different, so it's probably a good idea to have both. i'm still not sure if i really like the gpio-nop macro; it is at least a little odd, but i don't dislike it enough to not be ok with adding it. that gpios that are present in the gpio override table, but not in the gpio base table get ignored is still a bug though; planning to rebase and look into CB:43050 to get that one fixed