Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Kapil Porwal, Tarun, Tim Crawford.
Subrata Banik has posted comments on this change by Tim Crawford. ( https://review.coreboot.org/c/coreboot/+/82731?usp=email )
Change subject: soc/intel/mtl: Set HDA subsystem ID during FSP-M ......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS2: @kapilporwal@google.com can you please take a look?
Commit Message:
https://review.coreboot.org/c/coreboot/+/82731/comment/5e7cc160_4e2c90af?usp... : PS2, Line 7: Set HDA subsystem ID during FSP-M
We are using FSP d.0.97.10.
This is what we validated SiC_Version_0D.00.A8.20
Here is cbmem from CB:82609:
It does try to set the override SSID for HDA:
Are you saying FSP-S tries to override the HDA SSID ?
[DEBUG] PCI: 00:00:1f.3 subsystem <- 1558/a763 [DEBUG] PCI: 00:00:1f.3 cmd <- 02
But there is no subsystem detected in Linux:
$ lspci -s 1f.3 -vnn 00:1f.3 Audio device [0403]: Intel Corporation Device [8086:7e28] (rev 20) Flags: bus master, fast devsel, latency 64, IRQ 215, IOMMU group 11 Memory at b2830000 (64-bit, non-prefetchable) [size=16K] Memory at bee00000 (64-bit, non-prefetchable) [size=2M] Capabilities: <access denied> Kernel driver in use: snd_hda_intel Kernel modules: snd_hda_intel, snd_sof_pci_intel_mtl