Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/81564?usp=email )
(
4 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: mb/google/rex/var/deku: Swap LAN device indices for correct MAC address ......................................................................
mb/google/rex/var/deku: Swap LAN device indices for correct MAC address
Deku has two Ethernet ports. Currently both get assigned the wrong MAC address due to the LAN devices indices being swapped and vpd ethernet_mac0() affects device eth1 and vpd ethernet_mac1() affects device eth0.
Correct the device indices for LAN devices so ethernet_mac[0-1] in vpd can apply to the correct ethernet ports.
BUG=b:320203629 BRANCH=firmware-rex-15709.B TEST=vpd -s ethernet_mac0=<mac address0> vpd -s ethernet_mac1=<mac address1> reboot the system and check ifconfig eth0 and eth1 MAC addresses are fetched correctly
Change-Id: Id1508104cbb5cf0a234f34f9db19cc535fdb634b Signed-off-by: Tony Huang tony-huang@quanta.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/81564 Reviewed-by: Eric Lai ericllai@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Paul Menzel paulepanter@mailbox.org Reviewed-by: Subrata Banik subratabanik@google.com Reviewed-by: Derek Huang derekhuang@google.com --- M src/mainboard/google/rex/variants/deku/overridetree.cb 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: Subrata Banik: Looks good to me, approved Derek Huang: Looks good to me, approved Eric Lai: Looks good to me, approved build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/rex/variants/deku/overridetree.cb b/src/mainboard/google/rex/variants/deku/overridetree.cb index 0a383eb..ab0c6dc 100644 --- a/src/mainboard/google/rex/variants/deku/overridetree.cb +++ b/src/mainboard/google/rex/variants/deku/overridetree.cb @@ -83,7 +83,7 @@ chip drivers/net register "customized_leds" = "0x05af" register "wake" = "GPE0_DW0_01" # GPP_D01 - register "device_index" = "0" + register "device_index" = "1" register "add_acpi_dma_property" = "true" device pci 00.0 on end end @@ -98,7 +98,7 @@ chip drivers/net register "customized_leds" = "0x05af" register "wake" = "GPE0_DW1_04" # GPP_E04 - register "device_index" = "1" + register "device_index" = "0" register "add_acpi_dma_property" = "true" device pci 00.0 on end end