[L] Change in coreboot[master]: soc/mediatek/mt8188: Add ddp driver to support eDP output
Attention is currently required from: Hung-Te Lin, Yu-Ping Wu.
Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68487 )
Change subject: soc/mediatek/mt8188: Add ddp driver to support eDP output ......................................................................
Patch Set 6:
(8 comments)
File src/soc/mediatek/mt8188/ddp.c:
https://review.coreboot.org/c/coreboot/+/68487/comment/f8b07a04_26bacc13 PS5, Line 1:
`OR MIT`? […]
Done see CB:68759
https://review.coreboot.org/c/coreboot/+/68487/comment/273863a6_3edea540 PS5, Line 82: write32(®s->size, width << 16 | height);
Blank line above.
Done
https://review.coreboot.org/c/coreboot/+/68487/comment/40a71b4a_4d3f24ab PS5, Line 90: write32(®s->size, width << 16 | height);
Same
Done
https://review.coreboot.org/c/coreboot/+/68487/comment/a5c71b96_4f99a176 PS5, Line 97: = 0
No need to initialize.
Done
https://review.coreboot.org/c/coreboot/+/68487/comment/bc287819_27e2a4f0 PS5, Line 98: u32 pixel_clk = width * height * vrefresh;
const
Done
https://review.coreboot.org/c/coreboot/+/68487/comment/036d7fd8_70f160a5 PS5, Line 131: write32
write32p
Done
File src/soc/mediatek/mt8188/include/soc/ddp.h:
https://review.coreboot.org/c/coreboot/+/68487/comment/5f958cdb_d2f4f3bf PS5, Line 54: static struct mmsys_cfg_regs *const mmsys_cfg = (void *)VDOSYS0_BASE;
Blank line above.
Done
https://review.coreboot.org/c/coreboot/+/68487/comment/9b8c1877_1c132565 PS5, Line 167: static struct disp_mutex_regs *const disp_mutex = (void *)DISP_MUTEX_BASE;
Blank line above.
Done
-
Rex-BC Chen (Code Review)