[S] Change in coreboot[main]: mainboard/google/brox: Add FW_CONFIG and SKU definitions to support l... - coreboot-gerrit

1 Aug 2024


      Bob Moragues has posted comments on this change by Bob Moragues. ( https://review.coreboot.org/c/coreboot/+/82630?usp=email )
Change subject: mainboard/google/brox: Add FW_CONFIG and SKU definitions to support lotso
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/brox/variants/brox/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/82630/comment/5c4bd1c5_1b578ff3?usp... :
PS3, Line 19: 		option AUDIO_REALTEK_ALC3287		2
...
Yeah, as Shelley pointed out each variant can have its own FW_CONFIG and hence no need to align them […]
Done
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/82630?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I52cf42b79eff91ab2b4e98a7b5961310e60f2ea7
Gerrit-Change-Number: 82630
Gerrit-PatchSet: 3
Gerrit-Owner: Bob Moragues moragues@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Shelley Chen shchen@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Bob Moragues moragues@google.com
Gerrit-CC: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com
Gerrit-Comment-Date: Thu, 01 Aug 2024 18:38:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shelley Chen shchen@google.com
Comment-In-Reply-To: Bob Moragues moragues@google.com
Comment-In-Reply-To: Karthik Ramasubramanian kramasub@google.com