Attention is currently required from: Benjamin Doron, Kyösti Mälkki, Lance Zhao, Lean Sheng Tan, Nico Huber, Paul Menzel, Tim Wawrzynczak.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75677?usp=email )
Change subject: acpi: Add a debug option to print out tables in ACPICA compatible hex
......................................................................
Patch Set 7:
(1 comment)
File src/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/75677/comment/95555b77_9854fbac :
PS6, Line 1864: } else if ((all_zero == 2) || (all_one == 2)) {
: printk(BIOS_SPEW, "...\n");
: }
Looking into `acpixtract`, it seems to completely ignore the offsets.
So, yeah, nothing but printing every single byte will work directly.
Alternatively, one could run the data through a better hexdump parser,
but meh, not everybody has `xxd` installed.
Btw. it looks like we don't need the "%c" part. It seems to just look for
` .*:( *[0-9A-F]{2}){16}` and discards the rest.
acpidump from ACPICA does also generate that %c part.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75677?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7b5d879014563f7a2e1f70c45cf871ba72f142dc
Gerrit-Change-Number: 75677
Gerrit-PatchSet: 7
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Lance Zhao
lance.zhao@gmail.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Mon, 12 Jun 2023 10:48:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment