Maxim Polyakov has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44473 )
Change subject: util/intelp2m/apl: Remove unused plat-spec function ......................................................................
util/intelp2m/apl: Remove unused plat-spec function
Change-Id: I42074387a08b66b038ad2939f31be263eaa3af0e Signed-off-by: Maxim Polyakov max.senia.poliak@gmail.com --- M util/intelp2m/platforms/apl/macro.go 1 file changed, 0 insertions(+), 26 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/44473/1
diff --git a/util/intelp2m/platforms/apl/macro.go b/util/intelp2m/platforms/apl/macro.go index 4288fa4..0364067 100644 --- a/util/intelp2m/platforms/apl/macro.go +++ b/util/intelp2m/platforms/apl/macro.go @@ -37,32 +37,6 @@ // remmap is not required because it is the same as common. func (PlatformSpecific) RemmapRstSrc() {}
-// Adds the PADRSTCFG parameter from DW0 to the macro as a new argument -// return: macro -func (PlatformSpecific) Rstsrc() { - macro := common.GetMacro() - dw0 := macro.Register(PAD_CFG_DW0) - // See src/soc/intel/apollolake/gpio_apl.c: - // static const struct reset_mapping rst_map[] = { - // { .logical = PAD_CFG0_LOGICAL_RESET_PWROK, .chipset = 0U << 30 }, - // { .logical = PAD_CFG0_LOGICAL_RESET_DEEP, .chipset = 1U << 30 }, - // { .logical = PAD_CFG0_LOGICAL_RESET_PLTRST, .chipset = 2U << 30 }, - // }; - - var resetsrc = map[uint8]string{ - 0: "PWROK", - 1: "DEEP", - 2: "PLTRST", - } - str, valid := resetsrc[dw0.GetResetConfig()] - if !valid { - // 3h = Reserved (implement as setting 0h) - dw0.CntrMaskFieldsClear(common.PadRstCfgMask) - str = "PWROK" - } - macro.Separator().Add(str) -} - // Adds The Pad Termination (TERM) parameter from DW1 to the macro as a new argument // return: macro func (PlatformSpecific) Pull() {
Maxim Polyakov has removed Mario Scheithauer from this change. ( https://review.coreboot.org/c/coreboot/+/44473 )
Change subject: util/intelp2m/apl: Remove unused plat-spec function ......................................................................
Removed reviewer Mario Scheithauer.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44473 )
Change subject: util/intelp2m/apl: Remove unused plat-spec function ......................................................................
Patch Set 3: Code-Review+2
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44473 )
Change subject: util/intelp2m/apl: Remove unused plat-spec function ......................................................................
Patch Set 3: Code-Review+1
Michael Niewöhner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44473 )
Change subject: util/intelp2m/apl: Remove unused plat-spec function ......................................................................
util/intelp2m/apl: Remove unused plat-spec function
Change-Id: I42074387a08b66b038ad2939f31be263eaa3af0e Signed-off-by: Maxim Polyakov max.senia.poliak@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/44473 Reviewed-by: Michael Niewöhner foss@mniewoehner.de Reviewed-by: Matt DeVillier matt.devillier@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M util/intelp2m/platforms/apl/macro.go 1 file changed, 0 insertions(+), 26 deletions(-)
Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, but someone else must approve Michael Niewöhner: Looks good to me, approved
diff --git a/util/intelp2m/platforms/apl/macro.go b/util/intelp2m/platforms/apl/macro.go index 4288fa4..0364067 100644 --- a/util/intelp2m/platforms/apl/macro.go +++ b/util/intelp2m/platforms/apl/macro.go @@ -37,32 +37,6 @@ // remmap is not required because it is the same as common. func (PlatformSpecific) RemmapRstSrc() {}
-// Adds the PADRSTCFG parameter from DW0 to the macro as a new argument -// return: macro -func (PlatformSpecific) Rstsrc() { - macro := common.GetMacro() - dw0 := macro.Register(PAD_CFG_DW0) - // See src/soc/intel/apollolake/gpio_apl.c: - // static const struct reset_mapping rst_map[] = { - // { .logical = PAD_CFG0_LOGICAL_RESET_PWROK, .chipset = 0U << 30 }, - // { .logical = PAD_CFG0_LOGICAL_RESET_DEEP, .chipset = 1U << 30 }, - // { .logical = PAD_CFG0_LOGICAL_RESET_PLTRST, .chipset = 2U << 30 }, - // }; - - var resetsrc = map[uint8]string{ - 0: "PWROK", - 1: "DEEP", - 2: "PLTRST", - } - str, valid := resetsrc[dw0.GetResetConfig()] - if !valid { - // 3h = Reserved (implement as setting 0h) - dw0.CntrMaskFieldsClear(common.PadRstCfgMask) - str = "PWROK" - } - macro.Separator().Add(str) -} - // Adds The Pad Termination (TERM) parameter from DW1 to the macro as a new argument // return: macro func (PlatformSpecific) Pull() {
-
Matt DeVillier (Code Review) -
Maxim Polyakov (Code Review)
-
Michael Niewöhner (Code Review)