Attention is currently required from: Zhuohao Lee.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56308 )
Change subject: mb/google/brya: add BASEBOARD_DIR to support different baseboard
......................................................................
Patch Set 1:
(3 comments)
File src/mainboard/google/brya/Kconfig:
https://review.coreboot.org/c/coreboot/+/56308/comment/da4e51ac_a57c791f
PS1, Line 1: BOARD_GOOGLE_BASEBOARD_BRYA
Yes, i'm going to push another patch for the Brask. I'll refer to the CL you provide. […]
Ack
https://review.coreboot.org/c/coreboot/+/56308/comment/6e8c2582_006f5987
PS1, Line 46: CHROMEOS_DRAM_PART_NUMBER_IN_CBI
Yes, i'll submit another CL to change the memory setting.
Ack
https://review.coreboot.org/c/coreboot/+/56308/comment/c5435880_5fdcba43
PS1, Line 77: BOARD_GOOGLE_BRYA0
yes, i'll change this too.
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56308
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic99e42dbbd27fa3e1f6cb3a1b5daee1c8c7b1083
Gerrit-Change-Number: 56308
Gerrit-PatchSet: 1
Gerrit-Owner: Zhuohao Lee
zhuohao@chromium.org
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Zhuohao Lee
zhuohao@google.com
Gerrit-Attention: Zhuohao Lee
zhuohao@google.com
Gerrit-Attention: Zhuohao Lee
zhuohao@chromium.org
Gerrit-Comment-Date: Fri, 16 Jul 2021 07:46:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Zhuohao Lee
zhuohao@google.com
Gerrit-MessageType: comment