Attention is currently required from: Krystian Hebel, Maciej Pijanowski, Paul Menzel, Tim Crawford.
Michał Kopeć has posted comments on this change by Michał Kopeć. ( https://review.coreboot.org/c/coreboot/+/82673?usp=email )
Change subject: mb/novacustom: add V5x0TU board (Meteor Lake) ......................................................................
Patch Set 22:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/82673/comment/69975ac5_60002d46?usp... : PS21, Line 9: boards
laptop or desktop?
Laptop, added to the commit message.
https://review.coreboot.org/c/coreboot/+/82673/comment/652f414c_cc08c2d6?usp... : PS21, Line 17: - DDR5 SODIMM in slot RAM2
What about other slot(s), doesn't work or not tested?
RAM1 slot works, but needs CB:52731 and CB:82733
https://review.coreboot.org/c/coreboot/+/82673/comment/b86550db_fd905b7c?usp... : PS21, Line 20: - Video outputs in OS and firmware
What method do you use?
FSP GOP - Added to the commit msg
https://review.coreboot.org/c/coreboot/+/82673/comment/dcda6631_9aa17c66?usp... : PS21, Line 25:
Please document where the VBT comes from.
Done
File src/mainboard/novacustom/mtl-h/vboot-rwab.fmd:
https://review.coreboot.org/c/coreboot/+/82673/comment/b0f41a77_a3c96e96?usp... : PS21, Line 15: # MTL does not support a region crossing this boundary,
Is this caused by MTL specifically? If the code were aware of this lack of continuity (e.g. […]
The discontinuous extended bios window exists since Alder Lake. This is based on google/rex fmap which has the same comment, and google/brya ADL fmaps also have it.
-
Michał Kopeć (Code Review)