Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal, Eric Lai.
Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74620 )
Change subject: soc/intel/common: add power limits update support for variants
......................................................................
Patch Set 1:
(2 comments)
File src/soc/intel/common/block/include/intelblocks/power_limit.h:
https://review.coreboot.org/c/coreboot/+/74620/comment/d6579945_fa84f6db
PS1, Line 45: struct cpu_power_limits {
: uint16_t mchid;
: u8 cpu_tdp;
: unsigned int pl1_min_power;
: unsigned int pl1_max_power;
: unsigned int pl2_min_power;
: unsigned int pl2_max_power;
: unsigned int pl4_power;
: };
would you consider using this data structure inside brya as well ? https://github. […]
Ack.
File src/soc/intel/common/block/power_limit/power_limit.c:
https://review.coreboot.org/c/coreboot/+/74620/comment/522d3f43_2ecb97f1
PS1, Line 238: variant
soc_update_power_limits is better for common code.
This function would get called from varaints so prefer to keep it as it is.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74620
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I414715f211d816bbfad03a673ca96dd5df94caeb
Gerrit-Change-Number: 74620
Gerrit-PatchSet: 1
Gerrit-Owner: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Tue, 25 Apr 2023 11:19:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment