Attention is currently required from: Hung-Te Lin, Jarried Lin, Paul Menzel, Yidi Lin.
Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/83923?usp=email )
Change subject: soc/mediatek/mt8196: Add NOR-Flash support ......................................................................
Patch Set 10:
(2 comments)
File src/soc/mediatek/mt8196/include/soc/spi.h:
https://review.coreboot.org/c/coreboot/+/83923/comment/c15fb413_35a5b2cb?usp... : PS10, Line 12: Can we add a comment explaining what SNFC stands for (I found the term on https://www.mouser.com/datasheet/2/1074/MTK_MT8370_Application_Processor_Dat...
``` Initialize Serial NOR Flash Controller (SNFC). ```
File src/soc/mediatek/mt8196/spi.c:
https://review.coreboot.org/c/coreboot/+/83923/comment/00b04785_9ff8264a?usp... : PS10, Line 17: #define PAD_FUNC(name, func) {GPIO(name), PAD_##name##_FUNC_##func} : #define PAD_FUNC_GPIO(name) {GPIO(name), 0} Not used