Change in coreboot[master]: [RFC] smp/spinlock: Use compiler builtins - coreboot-gerrit

4 Jan 2022


      Attention is currently required from: Raul Rangel, Arthur Heymans, Kyösti Mälkki.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60253 )
Change subject: [RFC] smp/spinlock: Use compiler builtins
......................................................................
Patch Set 2:
(1 comment)
File src/include/smp/spinlock.h:
https://review.coreboot.org/c/coreboot/+/60253/comment/30e54a47_e3d1b5de 
PS2, Line 28: cpu_relax
dumb question from me... this looks like a no-op for non-x86 archs, so is this spinlock even useful for non-x86 anyway? looks like this "relax" terminology may be coming from the kernel, which does have some implementations for other archs.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/60253
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6694784aa0810cd877886ef95434f62e3aefce6c
Gerrit-Change-Number: 60253
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Raul Rangel rrangel@chromium.org
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Attention: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Comment-Date: Tue, 04 Jan 2022 21:55:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment