Felix Held has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/84431?usp=email )
Change subject: sconfig: Move config_of_soc from device.h to static.h
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
Patchset:
PS3:
i like where this is going
only semi-related to this patch and more something for when all patches from this patch topic have landed, but it would make things a bit clearer when static.[c,h] would get renamed to static_devicetree.[c,h] to clarify that those are autogenerated from the devicetree files
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84431?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7c40135bf2815093b81e47201c38b7d0a6ac8fa8
Gerrit-Change-Number: 84431
Gerrit-PatchSet: 3
Gerrit-Owner: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Wed, 02 Oct 2024 19:40:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes