Attention is currently required from: Felix Singer, Paul Menzel, Reto Buerki.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80261?usp=email )
Change subject: mb/up/squared: Make mini PCIe port mode configurable
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80261/comment/4e2a690f_57faf3e6 :
PS2, Line 9: Add ENABLE_MSATA config knob and pad configuration to put Mini PCIe port
: into mSATA mode.
So is it ok to postpone this to another patch (if required)?
I think we waited long enough. The patch doesn't change anything by default, so
should be regression free. If there is a reason to change Kconfig cosmetics, that
can be done later.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80261?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic2da1dd4252ebb5e373bc65418e321f566d4c10f
Gerrit-Change-Number: 80261
Gerrit-PatchSet: 3
Gerrit-Owner: Reto Buerki
reet@codelabs.ch
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Reto Buerki
reet@codelabs.ch
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Tue, 16 Apr 2024 12:27:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Felix Singer
service+coreboot-gerrit@felixsinger.de
Comment-In-Reply-To: Reto Buerki
reet@codelabs.ch
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment