Attention is currently required from: Chen, Gang C, Christian Walter, Jincheng Li, Johnny Lin, Jonathan Zhang, Jérémy Compostella, Lean Sheng Tan, Patrick Rudolph, Shuo Liu, Tim Chu.
Arthur Heymans has posted comments on this change by Shuo Liu. ( https://review.coreboot.org/c/coreboot/+/84314?usp=email )
Change subject: soc/intel/xeon_sp: Reserve PRMRR
......................................................................
Patch Set 1:
(4 comments)
File src/cpu/x86/mtrr/mtrr.c:
https://review.coreboot.org/c/coreboot/+/84314/comment/7bc17768_0723e2c3?usp... :
PS1, Line 115: static inline uint64_t range_entry_base_mtrr_addr(struct range_entry *r)
: {
: return PHYS_TO_RANGE_ADDR(range_entry_base(r));
: }
:
: static inline uint64_t range_entry_end_mtrr_addr(struct range_entry *r)
: {
: return PHYS_TO_RANGE_ADDR(range_entry_end(r));
: }
I suppose this could be exposed intead of a new function?
File src/include/cpu/x86/mtrr.h:
https://review.coreboot.org/c/coreboot/+/84314/comment/a088a6e4_af7a4d2f?usp... :
PS1, Line 130: uint64_t calculate_var_mtrr_size(uint64_t mask);
use a static inline.
File src/soc/intel/xeon_sp/uncore.c:
https://review.coreboot.org/c/coreboot/+/84314/comment/3ff17cb5_9c038de9?usp... :
PS1, Line 176: msr.hi << 32 | msr.lo;
there is msr.raw now to avoid this.
https://review.coreboot.org/c/coreboot/+/84314/comment/f0ac4867_e0b5e9bb?usp... :
PS1, Line 340: get_prmrr_count
do you know that all generations support 7 of these registers, which the weak function suggests? if not exception will be thrown.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84314?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I81d17b1376459510f7c0d43ba4b519b1f2bd3e1f
Gerrit-Change-Number: 84314
Gerrit-PatchSet: 1
Gerrit-Owner: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Chen, Gang C
gang.c.chen@intel.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Jincheng Li
jincheng.li@intel.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Attention: Chen, Gang C
gang.c.chen@intel.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Shuo Liu
shuo.liu@intel.com
Gerrit-Attention: Jincheng Li
jincheng.li@intel.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Thu, 12 Sep 2024 10:34:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No