Attention is currently required from: Nico Huber, Arthur Heymans, Patrick Rudolph. Hello Nico Huber, Arthur Heymans, Patrick Rudolph,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/55214
to review the following change.
Change subject: cpu/intel/haswell/acpi.c: Do not report P_BLK ......................................................................
cpu/intel/haswell/acpi.c: Do not report P_BLK
Even if IO MWAIT redirection were enabled, the base address is wrong. Moreover, the register resource descriptors for all reported C-states use the FFixedHW address space, not I/O.
Change-Id: Ic2faaafbe4928994aeeab8098d8e0fb6703d203d Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/cpu/intel/haswell/acpi.c 1 file changed, 2 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/55214/1
diff --git a/src/cpu/intel/haswell/acpi.c b/src/cpu/intel/haswell/acpi.c index 8eec704..f20d446 100644 --- a/src/cpu/intel/haswell/acpi.c +++ b/src/cpu/intel/haswell/acpi.c @@ -333,7 +333,7 @@
void generate_cpu_entries(const struct device *device) { - int coreID, cpuID, pcontrol_blk = get_pmbase(), plen = 6; + int coreID, cpuID; int totalcores = dev_count_cpu(); int cores_per_package = get_logical_cores_per_package(); int numcpus = totalcores/cores_per_package; @@ -343,15 +343,9 @@
for (cpuID = 1; cpuID <= numcpus; cpuID++) { for (coreID = 1; coreID <= cores_per_package; coreID++) { - if (coreID > 1) { - pcontrol_blk = 0; - plen = 0; - } - /* Generate processor _SB.CPUx */ acpigen_write_processor( - (cpuID - 1) * cores_per_package+coreID - 1, - pcontrol_blk, plen); + (cpuID - 1) * cores_per_package+coreID - 1, 0, 0);
/* Generate P-state tables */ generate_P_state_entries(