[XS] Change in coreboot[main]: nvramcui: Fix main function signature - coreboot-gerrit

23 Aug 2024


      Attention is currently required from: Arthur Heymans, Nico Huber.
Angel Pons has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/84011?usp=email )
Change subject: nvramcui: Fix main function signature
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
File payloads/nvramcui/nvramcui.c:
https://review.coreboot.org/c/coreboot/+/84011/comment/c3ed3eb1_165fdde8?usp... :
PS1, Line 162: *argv
...
Isn't `char *argv[]` cannonical?
I've seen both, I prefer `char *argv[]` because it better conveys intent (`argv` is an array of strings)
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/84011?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia0c50224bd70503e884573fedf3bf33c134bba00
Gerrit-Change-Number: 84011
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Comment-Date: Fri, 23 Aug 2024 10:02:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber nico.h@gmx.de