Attention is currently required from: Michał Żygowski, Michał Kopeć.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68448 )
Change subject: mainboard/msi/ms7d25: Add support for DDR5 variant ......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/msi/ms7d25/romstage_fsp_params.c:
https://review.coreboot.org/c/coreboot/+/68448/comment/e9167d56_e1a4dfd2 PS2, Line 71: if (CONFIG(BOARD_MSI_Z690_A_PRO_WIFI_DDR4)) : memcfg_init(memupd, &ddr4_mem_config, &dimm_module_spd_info, false); : if (CONFIG(BOARD_MSI_Z690_A_PRO_WIFI)) : memcfg_init(memupd, &ddr5_mem_config, &dimm_module_spd_info, false); How about adding two additional Kconfig options for DDR4 / DDR5 to the mainboard Kconfig? This scales much better when more variants are added.
In mainboard `Kconfig`: ``` if BOARD_MSI_MS7D25
config HAS_MEMORY_DDR4 default n default y if BOARD_MSI_Z690_A_PRO_WIFI_DDR4
config HAS_MEMORY_DDR5 default n default y if BOARD_MSI_Z690_A_PRO_WIFI
endif ```
Here, in `romstage_fsp_params.c`: ``` if (CONFIG(HAS_MEMORY_DDR4)) memcfg_init(memupd, &ddr4_mem_config, &dimm_module_spd_info, false);
if (CONFIG(HAS_MEMORY_DDR5)) memcfg_init(memupd, &ddr5_mem_config, &dimm_module_spd_info, false); ```