Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34330 )
Change subject: devicetree: Use const device with config_of() ......................................................................
devicetree: Use const device with config_of()
Change-Id: Ic0bccd2dfb149139c03df29893f85c23e13c0c21 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/include/device/device.h 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/34330/1
diff --git a/src/include/device/device.h b/src/include/device/device.h index c2bdd63..89d42d5 100644 --- a/src/include/device/device.h +++ b/src/include/device/device.h @@ -298,7 +298,7 @@ void devtree_bug(const char *func, pci_devfn_t devfn); void __noreturn devtree_die(void);
-static inline DEVTREE_CONST void *config_of(DEVTREE_CONST struct device *dev) +static inline DEVTREE_CONST void *config_of(const struct device *dev) { if (dev && dev->chip_info) return dev->chip_info; @@ -308,7 +308,7 @@
static inline DEVTREE_CONST void *config_of_path(pci_devfn_t devfn) { - DEVTREE_CONST struct device *dev = pcidev_path_on_root(devfn); + const struct device *dev = pcidev_path_on_root(devfn); if (dev) return config_of(dev);
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34330 )
Change subject: devicetree: Use const device with config_of() ......................................................................
Patch Set 1:
How about I squash this with CB:34298 and rebase everything? Seems CB:34328 can now build.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34330 )
Change subject: devicetree: Use const device with config_of() ......................................................................
Patch Set 1:
Patch Set 1:
How about I squash this with CB:34298 and rebase everything? Seems CB:34328 can now build.
Makes sense.
Kyösti Mälkki has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/34330 )
Change subject: devicetree: Use const device with config_of() ......................................................................
Abandoned
squashed